Skip to content

minor improvements #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

minor improvements #4

wants to merge 2 commits into from

Conversation

@michaelsstuff
Copy link

@michaelsstuff michaelsstuff commented Jun 2, 2021

Hi,

  1. just changed which to command -v -> https://github.com/koalaman/shellcheck/wiki/SC2230
  2. PGREP was overwritten. didnt hurt as it never got called again, but still
  3. replaced if in if loop with more elif

@michaelsstuff
Update check_all_open_files.sh
e3b9cf9 
using command -v instead of which 
use single if elif loop, instead of nested loops
dont overwrite PGREP
@michaelsstuff
Update check_all_open_files.sh
f8f24cc 
command -v isntead of which
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@michaelsstuff